On Fri, Mar 1, 2019 at 4:30 PM Florian Westphal <fw@xxxxxxxxx> wrote: > > Karuna Grewal <karunagrewal98@xxxxxxxxx> wrote: > > Meta evaluation function is extended to suport NFT_META_TSTAMP_NS option > > by exposing the 64 bit timestamp of the packet to two 32 bit registers. > Other than this, this patch looks good. Please consider sending v3 once > you have nftables patches ready as well. I've a doubt in the nftables implementation for implementing the `-m time` support. I'm unable to get a proper idea of where the start and stop time comparison with the dest register's value takes place. >From my understanding of implementation, I've noticed that after parsing the rule and the meta expression is allocated, expression's primary evaluation function is invoked. Meanwhile, the kernel has the nft_meta_get_eval function setting the register with the relevant field and in nf_tables_core.h the registering of different nft_expr_types is accomplished. Could someone please give me some pointers about where this processing of the data set in the meta registers takes place? Thanks Karuna