On Fri, Feb 08, 2019 at 06:22:41PM +0100, Florian Westphal wrote: > Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > > On Fri, Feb 08, 2019 at 05:02:22PM +0100, Florian Westphal wrote: > > > Temporary kludge to remove all the expr->ops->type == ... patterns. > > > Followup patch will remove expr->ops, and make expr_ops() lookup > > > the correct expr_ops struct instead to reduce struct expr size. > > > > const struct datatype *dtype; > > > enum byteorder byteorder; > > > + enum expr_types etype:8; > > > > Probably use just type:8; ? > > > > expr->etype > > > > sounds a bit redundant, but not a deal breaker :-) > > There is aslo dtype, I wanted to avoid confusion. No problem :)
