Re: [iptables PATCH v3 2/3] nft: Introduce UDATA_TYPE_EBTABLES_POLICY

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 08, 2019 at 03:24:24PM +0100, Florian Westphal wrote:
> Phil Sutter <phil@xxxxxx> wrote:
> > This will be used later to identify ebtables user-defined chain policy
> > rules.
> > 
> > Signed-off-by: Phil Sutter <phil@xxxxxx>
> > ---
> >  iptables/nft.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/iptables/nft.c b/iptables/nft.c
> > index 8d0d10177f5ed..4010ccd51d5aa 100644
> > --- a/iptables/nft.c
> > +++ b/iptables/nft.c
> > @@ -1115,6 +1115,7 @@ int add_counters(struct nftnl_rule *r, uint64_t packets, uint64_t bytes)
> >  
> >  enum udata_type {
> >  	UDATA_TYPE_COMMENT,
> > +	UDATA_TYPE_EBTABLES_POLICY,
> 
> Pablo, do you see any problems with this?
> I'm a bit concerned native nft could clash with this.

Short-term best would be to extend enum udata_type in nftables'
include/rule.h by this type to avoid accidental reuse. Mid-term we
should move all the udata_type definitions into libnftnl along with
getters/setters to centralize management.

Cheers, Phil



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux