Re: [PATCH nf 1/2] netfilter: nft_compat: fix build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 04, 2019 at 06:42:05PM +0100, Florian Westphal wrote:
> The patch 'netfilter: nf_tables: unbind set in rule from commit path'
> changed .deactivate signature, so update nft_compat accordingly.
> 
> We only must make sure we unlink nft_xt from list before mutex
> is released, i.e. abort or commit phase is enough.

Yes, I'll append your description and will include that this is joint
work.

We still should bump xt->listcnt here, right?

        /* Re-use the existing match if it's already loaded. */
        list_for_each_entry(nft_match, &cn->nft_match_list, head) {
                struct xt_match *match = nft_match->ops.data;

                if (nft_match_cmp(match, mt_name, rev, family))
                        return &nft_match->ops;
        }

I mean, in case we find a matching in the cn->nft_match_list.

Thanks!



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux