Re: [PATCH nf-next 08/11] netfilter: nat: remove csum_update hook

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Florian,

I love your patch! Yet something to improve:

[auto build test ERROR on nf-next/master]

url:    https://github.com/0day-ci/linux/commits/Florian-Westphal/netfilter-nat-merge-ipv4-and-ipv6-nat-modules/20190201-082027
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: x86_64-randconfig-u0-02010335 (attached as .config)
compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   In file included from net//netfilter/nf_nat_proto.c:27:0:
   include/linux/netfilter_ipv6.h: In function 'nf_ip6_fragment':
   include/linux/netfilter_ipv6.h:87:9: error: implicit declaration of function 'ip6_fragment' [-Werror=implicit-function-declaration]
     return ip6_fragment(net, sk, skb, output);
            ^
   net//netfilter/nf_nat_proto.c: In function 'nf_csum_update':
>> net//netfilter/nf_nat_proto.c:496:3: error: implicit declaration of function 'nf_nat_ipv6_csum_update' [-Werror=implicit-function-declaration]
      nf_nat_ipv6_csum_update(skb, iphdroff, check, t, maniptype);
      ^
   cc1: some warnings being treated as errors

vim +/nf_nat_ipv6_csum_update +496 net//netfilter/nf_nat_proto.c

   485	
   486	static void nf_csum_update(struct sk_buff *skb,
   487				   unsigned int iphdroff, __sum16 *check,
   488				   const struct nf_conntrack_tuple *t,
   489				   enum nf_nat_manip_type maniptype)
   490	{
   491		switch (t->src.l3num) {
   492		case NFPROTO_IPV4:
   493			nf_nat_ipv4_csum_update(skb, iphdroff, check, t, maniptype);
   494			return;
   495		case NFPROTO_IPV6:
 > 496			nf_nat_ipv6_csum_update(skb, iphdroff, check, t, maniptype);
   497			return;
   498		}
   499	}
   500	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux