Re: [PATCH nf-next 02/11] netfilter: ipv6: avoid indirect calls for IPV6=y case

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Florian,

I love your patch! Yet something to improve:

[auto build test ERROR on nf-next/master]

url:    https://github.com/0day-ci/linux/commits/Florian-Westphal/netfilter-nat-merge-ipv4-and-ipv6-nat-modules/20190201-082027
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: i386-randconfig-x010-201904 (attached as .config)
compiler: gcc-8 (Debian 8.2.0-15) 8.2.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   In file included from net/netfilter/nf_queue.c:14:
   include/linux/netfilter_ipv6.h: In function 'nf_ip6_fragment':
>> include/linux/netfilter_ipv6.h:87:9: error: implicit declaration of function 'ip6_fragment'; did you mean 'nf_ip6_fragment'? [-Werror=implicit-function-declaration]
     return ip6_fragment(net, sk, skb, output);
            ^~~~~~~~~~~~
            nf_ip6_fragment
   cc1: some warnings being treated as errors

vim +87 include/linux/netfilter_ipv6.h

    73	
    74	static inline int
    75	nf_ip6_fragment(struct net *net, struct sock *sk, struct sk_buff *skb,
    76			int (*output)(struct net *, struct sock *, struct sk_buff *))
    77	{
    78	#ifdef CONFIG_IPV6_MODULE
    79		const struct nf_ipv6_ops *v6ops = nf_get_ipv6_ops();
    80	
    81		if (v6ops)
    82			return v6ops->fragment(net, sk, skb, output);
    83	
    84		kfree_skb(skb);
    85		return -EMSGSIZE;
    86	#else
  > 87		return ip6_fragment(net, sk, skb, output);
    88	#endif
    89	}
    90	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux