Hi Florian,
On Mon, 21 Jan 2019 14:46:47 +0100 Florian Westphal <fw@xxxxxxxxx> wrote:
>
> Stephen Rottwell reports:
> After merging the netfilter-next tree, today's linux-next build
> (powerpc ppc64_defconfig) failed like this:
>
> ERROR: "nf_conntrack_invert_icmpv6_tuple" [nf_conntrack.ko] undefined!
> ERROR: "nf_conntrack_icmpv6_packet" [nf_conntrack.ko] undefined!
> ERROR: "nf_conntrack_icmpv6_init_net" [nf_conntrack.ko] undefined!
> ERROR: "icmpv6_pkt_to_tuple" [nf_conntrack.ko] undefined!
> ERROR: "nf_ct_gre_keymap_destroy" [nf_conntrack.ko] undefined!
>
> icmpv6 related errors are due to lack of IS_ENABLED(CONFIG_IPV6) (no icmpv6
> support is builtin if kernel has CONFIG_IPV6=n), the
> nf_ct_gre_keymap_destroy error is due to lack of PROTO_GRE check.
>
> Fixes: a47c54048162 ("netfilter: conntrack: handle builtin l4proto packet functions via direct calls")
> Fixes: e2e48b471634 ("netfilter: conntrack: handle icmp pkt_to_tuple helper via direct calls")
> Fixes: 197c4300aec0 ("netfilter: conntrack: remove invert_tuple callback")
> Fixes: 2a389de86e4a ("netfilter: conntrack: remove l4proto init and get_net callbacks")
> Fixes: e56894356f60 ("netfilter: conntrack: remove l4proto destroy hook")
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Signed-off-by: Florian Westphal <fw@xxxxxxxxx>
> ---
> net/netfilter/nf_conntrack_core.c | 8 ++++++++
> net/netfilter/nf_conntrack_proto.c | 2 ++
> 2 files changed, 10 insertions(+)
>
> diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c
> index 171659aa69a1..a3e5232c2088 100644
> --- a/net/netfilter/nf_conntrack_core.c
> +++ b/net/netfilter/nf_conntrack_core.c
> @@ -274,8 +274,10 @@ nf_ct_get_tuple(const struct sk_buff *skb,
> tuple->dst.dir = IP_CT_DIR_ORIGINAL;
>
> switch (protonum) {
> +#if IS_ENABLED(CONFIG_IPV6)
> case IPPROTO_ICMPV6:
> return icmpv6_pkt_to_tuple(skb, dataoff, net, tuple);
> +#endif
So the question in my mind is what happens when conntrack is built in
to the kernel but IPv6 is built as a module?
--
Cheers,
Stephen Rothwell
Attachment:
pgpuSjhdaTkPY.pgp
Description: OpenPGP digital signature
