Re: [iptables PATCH 1/3] nft: Add new builtin chains to cache immediately

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pablo,

On Fri, Jan 18, 2019 at 02:46:44AM +0100, Pablo Neira Ayuso wrote:
> On Tue, Jan 15, 2019 at 11:23:03PM +0100, Phil Sutter wrote:
[...]
> > @@ -1216,8 +1217,11 @@ nft_rule_append(struct nft_handle *h, const char *chain, const char *table,
> >  		h->ops->print_rule(r, 0, FMT_PRINT_RULE);
> >  
> >  	c = nft_chain_find(h, table, chain);
> > -	if (c)
> > -		nftnl_chain_rule_add_tail(r, c);
> > +	if (!c) {
> > +		errno = ENOENT;
> > +		return 0;
> > +	}
> > +	nftnl_chain_rule_add_tail(r, c);
> 
> Next time, please don't add unrelated changes, this renders 'git
> annotate' useless, thanks.

Oh, you're right. This chunk is merely related to the first one. I'll
spend more attention to those things in future.

Sorry, Phil



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux