Hi Willem, On Thu, Jan 17, 2019 at 11:07:18AM -0500, Willem de Bruijn wrote: > On Wed, Jan 16, 2019 at 4:48 PM Phil Sutter <phil@xxxxxx> wrote: > > > > Content is rather sparse, but still better than no manpage at all. > > > > Cc: Willem de Bruijn <willemb@xxxxxxxxxx> > > Signed-off-by: Phil Sutter <phil@xxxxxx> > > Thanks for adding this, Phil. > > Content looks great to me. One inline question. Thanks for your review! > > diff --git a/utils/nfbpf_compile.8.in b/utils/nfbpf_compile.8.in > > new file mode 100644 > > index 0000000000000..d02979a5143ef > > --- /dev/null > > +++ b/utils/nfbpf_compile.8.in > > @@ -0,0 +1,70 @@ > > +.TH NFBPF_COMPILE 8 "" "@PACKAGE_STRING@" "@PACKAGE_STRING@" > > Are these @PACKAGE_STRING@ tokens placeholders? Yes, they are. Also as indicated by the filename, configure script will fill them in while removing the suffix from filename. This is analogous to how nfnl_osf manpage is integrated into iptables sources. Cheers, Phil
