On Mon, Jan 14, 2019 at 11:15:10PM +0100, Florian Westphal wrote: > Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > > On Sat, Jan 12, 2019 at 08:03:19AM +0800, wenxu@xxxxxxxxx wrote: > > > From: wenxu <wenxu@xxxxxxxxx> > > > > > > In the ip_rcv the skb go through the PREROUTING hook first, > > > Then jump in vrf device go through the same hook again. > > > When conntrack dnat work with vrf, there will be some conflict for rules. > > > Because the package go through the hook twice with different nf status > > > > Then, the first hook applies NAT, while the second is simply ignored. > > Yes, but re-entry occurs with munged addresses in case DNAT was applied. > I'm not sure about this patch either though. > > If vrf is used, then it seems its enough to add a 'meta iifname vr+ accept' > rule to prevent false matches/re-invocation. Then this is a misconfiguration issue. > If the name isn't enough, I think we should consider extending meta to > query 'interface is vrf' so userspace can add the 'don't re-do entire > ruleset for vrf' policy itself. This sounds good, this problem is solved via policy. > I am not sure kernel should auto-enforce bypass based on conntrack > state, there is no precedence for this and I don't like > arbitrarily-chosen behaviour. Agreed.
