Re: [iptables PATCH v4 3/5] xtables: Set errno in nft_rule_check() if chain not found

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pablo,

On Wed, Jan 09, 2019 at 05:25:45PM +0100, Pablo Neira Ayuso wrote:
> On Sun, Dec 30, 2018 at 08:06:10PM +0100, Phil Sutter wrote:
> [...]
> > diff --git a/iptables/xtables.c b/iptables/xtables.c
> > index 24a6e234bcf4b..da11e8cc159a0 100644
> > --- a/iptables/xtables.c
> > +++ b/iptables/xtables.c
> > @@ -1064,10 +1064,6 @@ void do_parse(struct nft_handle *h, int argc, char *argv[],
> >  					   p->chain);
> >  		}
> >  
> > -		if (!p->xlate && !nft_chain_exists(h, p->table, p->chain))
> > -			xtables_error(OTHER_PROBLEM,
> > -				      "Chain '%s' does not exist", p->chain);
> 
> After this chunk is applied I get this error:
> 
> # iptables-nft -I test
> iptables: Index of insertion too big.
> 
> We can probably get this aligned with legacy, ie.
> 
> iptables: No chain/target/match by that name.

I have a patch series dealing with any error message misalignment
between legacy and nft variants waiting to be submitted upstream. I just
didn't want to send too many series depending upon each other at once.
So you may consider this virtually fixed already. :)

Cheers, Phil



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux