Re: [PATCH nft] payload: refine payload expr merging

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 10, 2019 at 12:53:45PM +0100, Florian Westphal wrote:
> nf_tables can handle payload exprs for sizes <= sizeof(u32) via
> a direct operation from the eval loop, rather than a a call to
> the payload expression.  Two loads for four byte quantities
> are thus faster than a single load for an 8 byte load.
> 
> ip saddr 1.2.3.4 ip daddr 2.3.4.5
> 
> is faster with this applied, even though it involves
> two payload expressions and two compare operations, just because
> all of them can be handled from the main loop rather than calls
> to the payload expression.
> 
> Keep merging for linklayer and when at least one of the expressions
> is already exceeding the 4 byte limit, then it will be cheaper to do
> the merging.
> 
> Signed-off-by: Florian Westphal <fw@xxxxxxxxx>

Acked-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux