Re: [PATCH] net: nf_tables: Fix for endless loop when dumping ruleset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 08, 2019 at 11:15:41PM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> > If fine with that, I would prefer to take your patch v1 to fix the
> > endless loop problem (ie. this patch).
> 
> > diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
> > index e3ddd8e95e58..04d504a31e60 100644
> > --- a/net/netfilter/nf_tables_api.c
> > +++ b/net/netfilter/nf_tables_api.c
> > @@ -2350,7 +2350,7 @@ static int nf_tables_dump_rules(struct sk_buff *skb,
> >  		if (ctx && ctx->table && strcmp(ctx->table, table->name) != 0)
> >  			continue;
> >  
> > -		if (ctx && ctx->chain) {
> > +		if (ctx && ctx->table && ctx->chain) {
> 
> LGTM.

Thanks Florian, sending a follow up separated patch for this.



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux