On Sun, Dec 23, 2018 at 06:06:40PM +0100, Florian Westphal wrote: > Shawn Bohrer <sbohrer@xxxxxxxxxxxxxx> wrote: > > count_tree() computes the hash for searching and inserting trees based > > on the number of CONNCOUNT_SLOTS which is always greater than or equal > > to CONNCOUNT_LOCK_SLOTS. Thus tree_gc_worker() needs to use > > CONNCOUNT_SLOTS to find the tree and CONNCOUNT_LOCK_SLOTS to find the > > lock. > > What about removing CONNCOUNT_LOCK_SLOTS and use CONNCOUNT_SLOTS > everywhere instead? Sure, I'm fine with that. The only time they are different is when CONFIG_LOCKDEP is enabled. But since you appear to be the one who made them differnt when CONFIG_LOCKDEP is enabled I guess you are OK with the removal of CONNCOUNT_LOCK_SLOTS? I guess the idea was that fewer locks means less overhead when CONFIG_LOCKDEP is enabled? If everyone agrees I'll make that change and resubmit. -- Shawn
