On Thu, Nov 15, 2018 at 02:53:02PM +0100, Phil Sutter wrote: > Being able to omit the previously obligatory table name check when > iterating over the chain cache might help restore performance with large > rulesets in xtables-save and -restore. > > There is one subtle quirk in the code: flush_chain_cache() did free the > global chain cache if not called with a table name but didn't if a table > name was given even if it emptied the chain cache. In other places, > chain_cache being non-NULL prevented a cache update from happening, so > this patch establishes the same behaviour (for each individual chain > cache) since otherwise unexpected cache updates lead to weird problems. Applied, thanks Phil. I sent a few follow up patches on top of this. My idea is to constify the builtin_table and builtin_cache definitions, so we keep all ongoing internal states into the struct nft_handle. Thanks.
