On Sun, Nov 04, 2018 at 01:33:43AM +1100, Duncan Roe wrote: > On Mon, Oct 29, 2018 at 12:33:39PM +0100, Pablo Neira Ayuso wrote: [...] > > @@ -105,6 +103,8 @@ NFT_CTX_OUTPUT_STATELESS:: > > If stateless output has been requested then stateful data is not printed. Stateful data refers to those objects that carry run-time data, eg. the *counter* statement holds packet and byte counter values, making it stateful. > > NFT_CTX_OUTPUT_HANDLE:: > > Upon insertion into the ruleset, some elements are assigned a unique handle for identification purposes. For example, when deleting a table or chain, it may be identified either by name or handle. Rules on the other hand must be deleted by handle because there is no other way to uniquely identify them. These functions allow to control whether ruleset listings should include handles or not. > > +NFT_CTX_OUTPUT_JSON:: > > + If enabled at compile-time, libnftables accepts input in JSON format and is able to print output in JSON format as well. See *libnftables-json*(5) for a description of the supported schema. These functions control JSON output format, input is auto-detected. > > How about: > + If enabled at compile-time, libnftables accepts input in JSON format and is able to print output in JSON format as well. > + See *libnftables-json*(5) for a description of the supported schema. > + These functions control JSON output format, input is auto-detected. > > I.e. implement Phil's suggestion of a new line for each sentence. > I'd like to see the previous long line split similarly, but suggest to leave > that for a "reformat-only" patch with no change to content. That's fine. Would send you mind to send a patch? Thanks Duncan.
