Re: [PATCH iptables] iptables-tests: do not append xtables-multi to external commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Nov 03, 2018 at 02:42:47PM +0100, Pablo Neira Ayuso wrote:
> Lines starting by @ can be used to invoke an external command of any
> kind. Do not add xtables-multi here since we may want to execute a
> non-iptables command.

Hm, main problem here with this is rateest, that is used @ to invoke
iptables commands.

> Signed-off-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
> ---
>  iptables-test.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/iptables-test.py b/iptables-test.py
> index 331fe59d6199..f38e002d077c 100755
> --- a/iptables-test.py
> +++ b/iptables-test.py
> @@ -216,7 +216,7 @@ def run_test_file(filename, netns):
>          if line[0] == "@":
>              external_cmd = line.rstrip()[1:]
>              if netns:
> -                external_cmd = "ip netns exec ____iptables-container-test " + EXECUTEABLE + " " + external_cmd
> +                external_cmd = "ip netns exec ____iptables-container-test " + external_cmd
>              execute_cmd(external_cmd, filename, lineno)
>              continue
>  
> -- 
> 2.11.0
> 



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux