On Wed, Oct 17, 2018 at 09:46:07PM +0900, Weongyo Jeong wrote: > udp.h header isn't used at these files. So it's safe to remove. > > Signed-off-by: Weongyo Jeong <weongyo.linux@xxxxxxxxx> > --- > net/ipv4/netfilter/ipt_CLUSTERIP.c | 1 - > net/ipv4/netfilter/ipt_REJECT.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/net/ipv4/netfilter/ipt_CLUSTERIP.c b/net/ipv4/netfilter/ipt_CLUSTERIP.c > index 2c8d313..35984f4 100644 > --- a/net/ipv4/netfilter/ipt_CLUSTERIP.c > +++ b/net/ipv4/netfilter/ipt_CLUSTERIP.c > @@ -18,7 +18,6 @@ > #include <linux/slab.h> > #include <linux/ip.h> > #include <linux/tcp.h> It seems we can also remove tcp.h? > -#include <linux/udp.h> > #include <linux/icmp.h> And icmp.h? It would be good to have a careful look and remove all headers that we don't need in one go. Probably we can even remove checksum.h, it seems this file is actually including much more than it needs? Let me know, Thanks! > #include <linux/if_arp.h> > #include <linux/seq_file.h> > diff --git a/net/ipv4/netfilter/ipt_REJECT.c b/net/ipv4/netfilter/ipt_REJECT.c > index e8bed33..503ba09 100644 > --- a/net/ipv4/netfilter/ipt_REJECT.c > +++ b/net/ipv4/netfilter/ipt_REJECT.c > @@ -14,7 +14,6 @@ > #include <linux/skbuff.h> > #include <linux/slab.h> > #include <linux/ip.h> > -#include <linux/udp.h> > #include <linux/icmp.h> > #include <net/icmp.h> Probably same here with icmp.h header files, not sure we need them. > #include <linux/netfilter/x_tables.h> > -- > 2.7.4 >
