On Thu, 11 Oct 2018 at 19:17, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
>
Hi Pablo,
> On Wed, Oct 10, 2018 at 07:56:18PM +0200, Pablo Neira Ayuso wrote:
> > On Sun, Oct 07, 2018 at 12:09:32AM +0900, Taehee Yoo wrote:
> > > checkentry(tee_tg_check) should initialize priv->oif from dev if possible.
> > > But only netdevice notifier handler can set that.
> > > Hence priv->oif is always -1 until notifier handler is called.
> > >
> > > Fixes: 22265a5c3c10 ("netfilter: xt_TEE: resolve oif using netdevice notifiers")
> >
> > I think this should be:
> >
> > Fixes: 9e2f6c5d78db ("netfilter: Rework xt_TEE netdevice notifier")
> >
> > since this one deleted the register_netdevice_notifier() call that was
> > setting the output interface index.
>
> Applied, thanks.
>
> Fixed it here before applying, I just hope my Fixes: tag is correct.
> It it is not, just let me know, will wait a bit to push out changes.
Thank you for review and fixing the fix-tag!
I checked about register_netdevice_notifier(), it works as your mention!
so that your fix-tag is right.
Thanks!
