This nit was discovered when comparing do_commandeb() with do_commandeb_xlate(): Since 'cs' is initialized upon declaration already, initialization of field '.eb.bitmask' may be moved there as well. Signed-off-by: Phil Sutter <phil@xxxxxx> --- iptables/xtables-eb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/iptables/xtables-eb.c b/iptables/xtables-eb.c index 534714de7999a..68f12500e524d 100644 --- a/iptables/xtables-eb.c +++ b/iptables/xtables-eb.c @@ -769,6 +769,7 @@ int do_commandeb(struct nft_handle *h, int argc, char *argv[], char **table, struct xtables_match *m; struct iptables_command_state cs = { .argv = argv, + .eb.bitmask = EBT_NOPROTO, }; char command = 'h'; const char *chain = NULL; @@ -790,7 +791,6 @@ int do_commandeb(struct nft_handle *h, int argc, char *argv[], char **table, /* prevent getopt to spoil our error reporting */ optind = 0; opterr = false; - cs.eb.bitmask = EBT_NOPROTO; /* Getopt saves the day */ while ((c = getopt_long(argc, argv, -- 2.18.0