On Fri, Aug 17, 2018 at 12:00:24PM +0200, Pablo Neira Ayuso wrote: > On Fri, Aug 17, 2018 at 01:56:32PM +1000, Duncan Roe wrote: > > Commit 88456a7ef added #include <linux/netfilter_bridge.h> but that header needs > > the definition of IFNAMSIZ from <net/if.h> > > Hm, it must be c8a0e8c90e2d1, right? I'll amend it here before > applying, no problem. Yes it is c8a0e8c90e2d, Fri Aug 3 10:55:33 2018 +0200. > > BTW, if you can also post the build error so I will include it in the > commit description, it's a good practise. > > Thanks! I only have the log from "make V=1": > libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I../include -DDEFAULT_INCLUDE_PATH=\"/etc\" -g -DDEBUG -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wdeclaration-after-statement -Wsign-compare -Winit-self -Wformat-nonliteral -Wformat-security -Wmissing-format-attribute -Wcast-align -Wundef -Wbad-function-cast -Waggregate-return -Wunused -Wwrite-strings -g3 -ggdb -MT evaluate.lo -MD -MP -MF .deps/evaluate.Tpo -c evaluate.c -fPIC -DPIC -o .libs/evaluate.o > In file included from ../include/linux/netfilter_bridge.h:10:0, > from rule.c:32: > /usr/include/linux/if_pppox.h:42:20: error: 'IFNAMSIZ' undeclared here (not in a function) > char dev[IFNAMSIZ]; /* Local device to use */ > ^ > Makefile:687: recipe for target 'rule.lo' failed > make[3]: *** [rule.lo] Error 1 Cheers ... Duncan.
