On Wed, Aug 15, 2018 at 06:22:14PM +0200, Fernando Fernandez Mancera wrote:
> On 8/14/18 4:10 PM, Pablo Neira Ayuso wrote:
> > On Mon, Aug 13, 2018 at 06:57:08PM +0200, Fernando Fernandez Mancera wrote:
[...]
> > > + uloga("Loading '%s'.\n", ctx, buffer);
>
> I think we should remove uloga() and replace every "uloga(..)" with:
>
> if (ctx->debug_mask & NFT_DEBUG_NETLINK)
> nft_print(ctx->octx, "%s", f);
>
> because using uloga and nft_print at the same time we cannot use strings
> with format specifiers i.e: in this case nft prints "Loading '%s'." so it is
> not using the argument given as a "%s".
>
> I am going to replace it all if no objections.
Sure, go ahead.
