Re: [PATCH 1/3 nft v2] files: osf: copy iptables/utils/pf.os into nftables tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 14, 2018 at 03:24:00PM +0200, Fernando Fernandez Mancera wrote:
> El 14 de agosto de 2018 15:00:18 CEST, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> escribió:
> >On Mon, Aug 13, 2018 at 06:57:06PM +0200, Fernando Fernandez Mancera
> >wrote:
> >> diff --git a/files/osf/Makefile.am b/files/osf/Makefile.am
> >> new file mode 100644
> >> index 0000000..4c5c9ff
> >> --- /dev/null
> >> +++ b/files/osf/Makefile.am
> >> @@ -0,0 +1,2 @@
> >> +pkgsysconfdir = ${sysconfdir}/osf
> >> +dist_pkgsysconf_DATA = pf.os
> >
> >Instead of installing this under /etc/osf/ I think we can place this
> >under /etc/nftables/osf/.
> >
> >No need to resend I can update this here if no objections.
> 
> I agree with you, thanks.

Need to follow up with more request for changes. So please, send a v2 using:

+pkgsysconfdir = ${sysconfdir}/nftables/osf

You will also need to update files/Makefile.am

 install-data-hook:
-       ${SED} -i 's|@sbindir[@]|${sbindir}/|g' ${DESTDIR}${pkgsysconfdir}/*
+       ${SED} -i 's|@sbindir[@]|${sbindir}/|g' ${DESTDIR}${pkgsysconfdir}/*.nft

Otherwise sed will break.

Thanks.



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux