Hi Pablo, On Wed, Aug 08, 2018 at 07:21:49PM +0200, Pablo Neira Ayuso wrote: > On Wed, Aug 08, 2018 at 02:34:37AM +0530, Arushi Singhal wrote: > > changes in package dependencies for PDF creation (nft.pdf) from > > asciidoc. > > If I apply this patch, I can hit the following error: > > make[2]: Entering directory > '/home/git/nftables/doc' > a2x --doctype manpage --format manpage -D . libnftables-json.adoc > a2x --doctype manpage --format manpage -D . libnftables.adoc > a2x --doctype manpage --format pdf -D . libnftables-json.adoc > GEN nft.8 > a2x --doctype manpage --format pdf -D . libnftables.adoc > GEN nft.pdf > a2x: WARNING: --destination-dir option is only applicable to HTML based outputs > a2x: WARNING: --destination-dir option is only applicable to HTML based outputs > a2x: WARNING: --destination-dir option is only applicable to HTML based outputs > a2x: WARNING: --destination-dir option is only applicable to HTML based outputs > a2x: ERROR: "dblatex" -t pdf -p "/etc/asciidoc/dblatex/asciidoc-dblatex.xsl" -s "/etc/asciidoc/dblatex/asciidoc-dblatex.sty" "/home/git/nftables/doc/libnftables.xml" > returned non-zero exit status 1 > Makefile:673: recipe for target 'libnftables.pdf' failed > make[2]: *** [libnftables.pdf] Error 1 > make[2]: *** Waiting for unfinished jobs.... > a2x: ERROR: "dblatex" -t pdf -p "/etc/asciidoc/dblatex/asciidoc-dblatex.xsl" -s "/etc/asciidoc/dblatex/asciidoc-dblatex.sty" "/home/git/nftables/doc/libnftables-json.xml" > returned non-zero exit status 1 > Makefile:673: recipe for target 'libnftables-json.pdf' failed > make[2]: *** [libnftables-json.pdf] Error 1 > > Before this patch, I was all the time hitting: > > enable pdf documentation: no > > So I guess now PDF compilation is turned on, but it was not working. > > Does this generate the PDF file there? > > Thanks. I got that error as well from "make -j7" but *plain "make" runs to completion*. You get 3 pdfs created - one for each man page. Anyway the patch is wrong - you need to keep the test for dblatex and discard the subsequent duplicate test for a2x. After fixing that, the readline check failed (becaue it needs to specify -lncurses when building conftest). I have no idea why that didn't trip before, but fixed it anyway. Expect a patch shortly, Cheers ... Duncan.
