Re: [PATCH] nft: doc: fix make distcheck

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Aug 11, 2018 at 12:58:25PM +0530, Arushi Singhal wrote:
> On Wed, Aug 8, 2018 at 12:06 PM, Máté Eckl <ecklm94@xxxxxxxxx> wrote:
> 
> > On Wed, Aug 08, 2018 at 10:49:26AM +0530, Arushi Singhal wrote:
> > > fix make distcheck for conversion to asciidoc.
> > >
> > > Signed-off-by: Arushi Singhal <arushisinghal19971997@xxxxxxxxx>
> > > ---
> > >  doc/Makefile.am | 8 ++++----
> > >  1 file changed, 4 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/doc/Makefile.am b/doc/Makefile.am
> > > index 291bcc8..4d8cd98 100644
> > > --- a/doc/Makefile.am
> > > +++ b/doc/Makefile.am
> > > @@ -17,11 +17,11 @@ ASCIIDOCS = ${ASCIIDOC_MAIN} ${ASCIIDOC_INCLUDES}
> > >
> > >  pdfdir=${docdir}/pdf
> > >
> > > -nft.8: ${ASCIIDOCS}
> > > -     ${AM_V_GEN}${A2X} --doctype manpage --format manpage
> > ${ASCIIDOC_MAIN}
> > > +.txt.8: ${ASCIIDOCS}
> >
> > Why is this .txt suffix good? I applied the patch and I didn't notice any
> > change
> > in the output filename.
> > Nevertheless I don't see why one should include the input file extension
> > in the
> > output file name.
> >
> > > +     ${AM_V_GEN}${A2X} --doctype manpage --format manpage $<
> > >
> > > -nft.pdf: ${ASCIIDOCS}
> > > -     ${AM_V_GEN}${A2X} --doctype manpage --format pdf ${ASCIIDOC_MAIN}
> > > +.txt.pdf: ${ASCIIDOCS}
> >
> > Same question here.
> >
> 
> Hello Máté
> 
> Yes writing .txt.8 instead of nft.8 will not change the outputfile name, I
> just wrote it to follow the similar patten followed for ".adoc.pdf"
> insteasd of writing it as "libnftables.pdf".
> 
> Thanks
> Arushi

Okay, thanks for explaining.

> 
> >
> > > +     ${AM_V_GEN}${A2X} --doctype manpage --format pdf $<
> > >
> > >  .adoc.pdf:
> > >       a2x --doctype manpage --format pdf -D ${builddir} $<
> > > --
> > > 2.7.4
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe
> > netfilter-devel" in
> > > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux