Re: [PATCH nf-next] netfilter: nft_osf: use OSF_GENRE_SIZE instead of IFNAMSIZ

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/06/2018 01:30 PM, Pablo Neira Ayuso wrote:
On Mon, Aug 06, 2018 at 01:24:17PM +0200, Fernando Fernandez Mancera wrote:
Right now, we have "MAXGENRELEN" defined in UAPI, so I am going to use it
instead of define OSF_GENRE_SIZE.

Oh I see.

This is 32 bytes long and we cannot change it because original xt_osf
structure relies on that. Changes would break the binary interface
which is a no-go.

We can probably place this in netfilter/nf_tables.h uapi file instead
so this is only used by nft_osf.

If we ever need more than 16 bytes, we can extend it to be 32 bytes.

OK?


OK, seems fine to me. Thanks

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux