Re: [PATCH 1/2 nft] src: use OSF_GENRE_SIZE instead of IFNAMSIZ in osf.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 06, 2018 at 01:15:24PM +0200, Fernando Fernandez Mancera wrote:
> As no "genre" in pf.os exceed 16 bytes of length, we reduce OSF_GENRE_SIZE
> parameter to 16 bytes and use it instead of IFNAMSIZ.
> 
> Signed-off-by: Fernando Fernandez Mancera <ffmancera@xxxxxxxxxx>
> ---
>  include/osf.h | 2 ++
>  src/osf.c     | 4 +---
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/osf.h b/include/osf.h
> index 715b04e..d4d0c19 100644
> --- a/include/osf.h
> +++ b/include/osf.h
> @@ -1,6 +1,8 @@
>  #ifndef NFTABLES_OSF_H
>  #define NFTABLES_OSF_H
>  
> +#define OSF_GENRE_SIZE	16

No need to define this, we should keep a copy of the osf.h uapi in the
nftables.

We usually cache header files that we don't install to make sure
software compiles in a standalone fashion, ie. with no external kernel
header dependencies.

So copy uapi header file to nftables git tree under the include
directory.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux