Re: [iptables PATCH 20/27] xtables-restore: Improve user-defined chain detection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Aug 04, 2018 at 04:18:16PM +0200, Florian Westphal wrote:
> Phil Sutter <phil@xxxxxx> wrote:
> > Legacy ebtables-save does not use a policy string of '-' to denote
> > user-defined chains but instead lists them with a policy of ACCEPT.
> 
> This gives
> 
> xtables-restore.c:336:24: warning: ‘curtable’ may be used uninitialized
> in this function [-Wmaybe-uninitialized]
>    if (p->tablename && (strcmp(p->tablename, curtable->name) != 0))

Hmm. My gcc doesn't print that warning, but it seems valid. Do you know
if it's allowed to restore a dump which does not state the table when
calling 'iptables-restore -T <foo>'?

> I've applied the series up to this point.

Thanks, Phil
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux