On Mon, Jul 23, 2018 at 12:26:31PM +0200, Jan Engelhardt wrote:
> On Monday 2018-07-23 12:06, Pablo Neira Ayuso wrote:
>
> >On Fri, Jul 20, 2018 at 04:41:11PM +0200, Fernando Fernandez Mancera wrote:
> >> Rename nf_osf.c to nfnetlink_osf.c as we introduce nfnetlink_osf which is
> >> the OSF infraestructure.
> >>
> >> Signed-off-by: Fernando Fernandez Mancera <ffmancera@xxxxxxxxxx>
> >> ---
> >> .../linux/netfilter/{nf_osf.h => nfnetlink_osf.h} | 2 +-
> >> .../linux/netfilter/{nf_osf.h => nfnetlink_osf.h} | 6 +++---
> >> include/uapi/linux/netfilter/xt_osf.h | 2 +-
> >> net/netfilter/Kconfig | 15 ++++++++++-----
> >> net/netfilter/Makefile | 2 +-
> >> net/netfilter/{nf_osf.c => nfnetlink_osf.c} | 2 +-
> >> 6 files changed, 17 insertions(+), 12 deletions(-)
> >> rename include/linux/netfilter/{nf_osf.h => nfnetlink_osf.h} (95%)
> >> rename include/uapi/linux/netfilter/{nf_osf.h => nfnetlink_osf.h} (96%)
> >
> >The uapi file we cannot rename. Anything in the uapi folder is set in
> >stone forever.
>
> Userspace such as iptables keeps copies of header files so that it
> always builds no matter what set of files the kernel offers.
Right, but we cannot assume users use iptables, they may develop their
own applications based on our binary interface. But I think this
rename is fine given uapi/linux/netfilter/nf_osf.h did not have users
so far, given that this is only useful for nft_osf.
Fernando, would you send a patch rename the header to nfnetlink_osf.h
as Jan suggested? I suggest you add a Suggested-by: tag. Explain in
the commit message that first client of this is nft_osf.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
