From: Florian Westphal <fw@xxxxxxxxx> Date: Sun, 22 Jul 2018 18:39:25 +0200 > 3. change meaning of ->done() so its always called once ->start() > was invoked (and returned 0), this requires audit of all > places that provide .done to make sure they won't trip. > > 3) seems to be what Tom intended when he added .start, so probably > best to investigate that first. Hmmm... Any time ->start() succeeds, we set cb_running to true. >From that point forward, ->done() will be called at some point at all of the locations that check if cb_running is true and set it to false. This may be deferred all the way to socket destruction, but it will eventually happens. Nothing sets cb_running to false without invoking the ->done() callback. Just because the individual dump invocations don't call ->done() does not mean it will not eventually happen. The dump callbacks, and thus the state data, is live across multiple rounds of recvmsg() calls by the user and that is as-designed. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
