On Tue, Jul 17, 2018 at 10:10:42PM +0200, Harsha Sharma wrote: > On Tue, Jul 17, 2018 at 9:47 PM, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > > On Tue, Jul 17, 2018 at 09:38:18PM +0200, Harsha Sharma wrote: > >> Hello, > >> > >> On Tue, Jul 17, 2018 at 5:44 PM, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > >> > On Tue, Jul 17, 2018 at 03:24:22PM +0200, Pablo Neira Ayuso wrote: > >> >> On Sat, Jul 14, 2018 at 12:28:02AM +0200, Harsha Sharma wrote: > >> >> > As, ctnl_untimeout is required by nft_ct, so move ctnl_timeout from > >> >> > nfnetlink_cttimeout to nf_conntrack_timeout and rename as nf_ct_timeout. > >> >> > >> >> Applied, thanks. > >> > > >> > Hm, there's a few kbuild test robot reports on this, I'm keeping it > >> > back until we clarify. > >> > > >> > net//netfilter/nfnetlink_cttimeout.c: In function 'ctnl_timeout_try_del': > >> >>> net//netfilter/nfnetlink_cttimeout.c:312:3: error: implicit > >> >>> declaration of function 'nf_ct_untimeout'; did you mean > >> >>> 'nf_ct_netns_put'? [-Werror=implicit-function-declaration] > >> > nf_ct_untimeout(net, timeout); > >> > ^~~~~~~~~~~~~~~ > >> > nf_ct_netns_put > >> > cc1: some warnings being treated as errors > >> > > >> > This one may be related to .config configuration that kbuild test > >> > robot is attaching. > >> > >> Ok, I'll wrap nf_ct_untimeout with CONFIG_NF_CONNTRACK_TIMEOUT. > > > > But nfnetlink_cttimeout should depend on CONFIG_NF_CONNTRACK_TIMEOUT > > from Kconfig, right? > > No, it is not. CONFIG_NF_CT_NETLINK_TIMEOUT does not depend on > NF_CONNTRACK_TIMEOUT. OK, so this is the problem. Could you send a patch so NF_CT_NETLINK_TIMEOUT depends on NF_CONNTRACK_TIMEOUT from Kconfig, coming before this one. Do so and resubmit. That should fix the problem. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
