On Mon, Jul 16, 2018 at 06:34:50PM +0200, Fernando Fernandez Mancera wrote: > On 07/16/2018 05:10 PM, Pablo Neira Ayuso wrote: > > > +int nf_osf_add_callback(struct net *net, struct sock *ctnl, > > > + struct sk_buff *skb, const struct nlmsghdr *nlh, > > > + const struct nlattr * const osf_attrs[], > > > + struct netlink_ext_ack *extack); > > > + > > > +int nf_osf_remove_callback(struct net *net, struct sock *ctnl, > > > + struct sk_buff *skb, const struct nlmsghdr *nlh, > > > + const struct nlattr * const osf_attrs[], > > > + struct netlink_ext_ack *extack); > > > > You don't need to place these function declararions in the .h file. > > > > Rule of thumb is: You only place declaration in header file that will > > be used by other .c files or other modules... > > > > These are internal, so... > > They are going to be used by xt_osf.c and nft_osf.c so we need to define > them here right? They should not be used from xt_osf.c, you can register the callbacks from nfnetlink_osf.c, from the module _init path. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
