Hi Stefano, On Mon, 9 Jul 2018, Stefano Brivio wrote: > On Mon, 9 Jul 2018 22:36:51 +0200 (CEST) > Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx> wrote: > > > I believe the only modifications which are required are up till this point > > in ip_set_list_set.c: ip_set_put_byindex(), moved outside of the > > call_rcu() call. However, the ip_set_put_byindex() calls should be placed > > after list_del_rcu() and list_replace_rcu(). > > This was also the first approach I took. With the changes you > suggested, I guess this should look like the diff at [1]. Is this what > you meant? > > However, list, flush and destroy are not serialised, so, with that > patch, I do actually hit the BUG_ON(set->ref == 0) in > ip_set_name_byindex(). That's why I think I can't rely on set->ref > anymore with those changes: Yes, you're right. I had some concerns with the second version of your patch and therefore looked for another way to solve the issue, badly. So, back to the second version, see my comments in my next mail. Best regards, Jozsef - E-mail : kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxxxxxx PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences H-1525 Budapest 114, POB. 49, Hungary -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
