Hi Pablo, I love your patch! Perhaps something to improve: [auto build test WARNING on nf-next/master] url: https://github.com/0day-ci/linux/commits/Pablo-Neira-Ayuso/netfilter-nf_osf-add-nf_osf_match_one/20180714-051307 base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> net/netfilter/nf_osf.c:267:24: sparse: Using plain integer as NULL pointer vim +267 net/netfilter/nf_osf.c 251 252 const char *nf_osf_find(const struct sk_buff *skb, 253 const struct list_head *nf_osf_fingers) 254 { 255 const struct iphdr *ip = ip_hdr(skb); 256 const struct nf_osf_user_finger *f; 257 unsigned char opts[MAX_IPOPTLEN]; 258 const struct nf_osf_finger *kf; 259 struct nf_osf_hdr_ctx ctx; 260 const struct tcphdr *tcp; 261 const char *genre = NULL; 262 263 memset(&ctx, 0, sizeof(ctx)); 264 265 tcp = nf_osf_hdr_ctx_init(&ctx, skb, ip, opts); 266 if (!tcp) > 267 return false; 268 269 list_for_each_entry_rcu(kf, &nf_osf_fingers[ctx.df], finger_entry) { 270 f = &kf->finger; 271 if (!nf_osf_match_one(skb, f, -1, &ctx)) 272 continue; 273 274 genre = f->genre; 275 break; 276 } 277 278 return genre; 279 } 280 EXPORT_SYMBOL_GPL(nf_osf_find); 281 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
