Florian Westphal <fw@xxxxxxxxx> wrote: > Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > > On Thu, Jul 12, 2018 at 01:03:00PM +0200, Florian Westphal wrote: > > > Fernando Fernandez Mancera <ffmancera@xxxxxxxxxx> wrote: > > > > +extern struct list_head nft_osf_fingers[2]; > > > > > > How is this going to be used? > > > > > > I find it weird to see this in netfilter core. > > > > We can also place it as a struct nft_object_ops, but we'll need some > > infrastructure to define singleton objects, ie. allow to add only one > > single instance of the 'osf' fingerprints object that can be used the > > rule. > > Why so complicated? [..] I did not intend to be negative. I am trying to review this but I have a hard time giving feedback because I do not understand what the end result is supposed to do, what service(s) it provides, etc. It would be good if intended usage could be illustrated with a few examples, it might make most of my questions obsolete. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
