Re: [PATCH RFC nft] src: meta: always prefix 'meta' for all tokens

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 03, 2018 at 04:16:51PM +0200, Florian Westphal wrote:
> got following bug report:
> 
> nft add ... ct mark set mark and 0x10
> 
> ... always sets 0.
> What reporter meant to write instead was 'ct mark',
> not 'mark'.
> 
> We can't just remove support for 'mark' and force
> 'meta mark', but we can start to discourage it by always
> printing the longer form.
> 
> Later on, we could start to print deprecation warning if needed.

Looks good to me.

> NB: Patch causes gazillion of test case warnings, I would fix those
> up of course.

Just fix it in the same patch. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux