Re: [PATCH nft] configure.ac: docbook2man invalid syntax error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Thu, 2018-06-28 at 12:20 +0200, Máté Eckl wrote:
> Hi,
> 
> It seems that I might be a bit late on this, but could you provide
> some details
> on what error occured with docbook2man being an alternative?
> I checked out the commit before yours (291f9a3) and I don't get any
> errors with
> doc generation (nor had I before my last pull).
> 
> On the other hand, ArchLinux seems not to have the the executables of
> the other
> alternatives (at least not with the same names), so I cannot compile
> nft now.

Ok, so this was done for ArchLinux. I did not manage to find an
operating system where it was working.

> 
> I attached the output of the compilation commands run at 291f9a3, I
> don't see any errors
> regarding man page generation so I don't understand why this patch is
> necessary.

On Fedora and Debian, docbook2man is wrapper and has a different syntax
so the command fails.

> 
> Maybe if you point out the bug, I can look after it.

A possible solution is to update configure.ac to check that docbook2man
(if found) accept the correct option.

BR,
--
Eric

> 
> Regards,
> Máté
> 
> On Mon, Jun 18, 2018 at 02:17:47PM +0200, Eric Leblond wrote:
> > docbook2man can not be used with the same option so let's remove
> > it from the alternative. Fedora and debian seems to be fine with
> > that.
> > ---
> >  configure.ac | 9 +++------
> >  1 file changed, 3 insertions(+), 6 deletions(-)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index 2a19733..88f0d74 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -56,14 +56,11 @@ AM_PROG_LIBTOOL
> >  
> >  AM_COND_IF([BUILD_MAN], [
> >  	AC_CHECK_PROG(DOCBOOK2X_MAN, [docbook2x-man], [docbook2x-
> > man], [no])
> > -	AC_CHECK_PROG(DOCBOOK2MAN, [docbook2man], [docbook2man],
> > [no])
> >  	AC_CHECK_PROG(DB2X_DOCBOOK2MAN, [db2x_docbook2man],
> > [db2x_docbook2man], [no])
> >  	AS_IF([test "$DOCBOOK2X_MAN" != "no"],
> > [DB2MAN="$DOCBOOK2X_MAN"],
> > -	      [AS_IF([test "$DOCBOOK2MAN" != "no"],
> > [DB2MAN="$DOCBOOK2MAN"],
> > -		     [AS_IF([test "$DB2X_DOCBOOK2MAN" != "no"],
> > -			    [DB2MAN="$DB2X_DOCBOOK2MAN"],
> > -			    [AC_MSG_ERROR([docbook2x-
> > man/db2x_docbook2man not found, required for building man pages])]
> > -		     )]
> > +	     [AS_IF([test "$DB2X_DOCBOOK2MAN" != "no"],
> > +		    [DB2MAN="$DB2X_DOCBOOK2MAN --xinclude"],
> > +		    [AC_MSG_ERROR([docbook2x-man/db2x_docbook2man
> > not found, required for building man pages])]
> >  	     )]
> >  	)
> >  	AC_SUBST(DB2MAN)
> > -- 
> > 2.17.1
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> > netfilter-devel" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
Eric Leblond <eric@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux