On Tuesday 2018-06-26 11:03, Máté Eckl wrote: >Isn't that an option to add these includes to CFLAGS variable? So that it would >be less redundant. Yes and no... No, because CFLAGS -- at least in the automake world, which I know ebtables is far from, but let's go with the thought anyway -- because CFLAGS is for the user to override. Placing mandatory -I arguments into a variable that gets completely reset is a recipe for more compile errors. But yeah, I get the point that mandatory flags should all be centralised in a var. I'll take that with me for the next patch. >> - $(CC) $(CFLAGS) $(LDFLAGS) $(PROGSPECS) -o $@ $^ -I$(KERNEL_INCLUDES) -Iinclude ; \ >> + $(CC) $(CFLAGS) $(LDFLAGS) $(PROGSPECS) -o $@ $^ -Iinclude/ -Iinclude ; \ > >There is a duplicate -Iinclude here. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
