On 26/06/18 07:48, Florian Westphal wrote:
John Crispin <john@xxxxxxxxxxx> wrote:
Currently traffic that hits the SW offloading path is not accounted for
and the conntrack counters will only show the first packet of the flow.
This patch adds a small helper function that gets called from the nf_hooks,
updating the accounting counters.
Not sure this is a good idea. With offload accouting might not be
available at all.
correct but this is the pure SW path and accounting should work. I have
patches that sit on top of Pablo's HW offloading code for MediaTek Arm
Silicon, where accounting is not possible. However with the QCOM IPQ806x
NSS engine which i am currently working on, per flow accounting is
indeed possible. Right now only the netdev counters get updated by sw
offloaded flows.
neigh_xmit(NEIGH_ARP_TABLE, outdev, &nexthop, skb);
+ nf_flow_offload_acct(flow, skb, dir);
Won't skb be already free'd here by xmit routine?
ah correct, the code worked, but its a clear use after free.
John
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
