Re: [PATCH] ebtables: Use double quotes in #include statements for local headers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pablo,

On Mon, Jun 04, 2018 at 10:05:15AM +0200, Pablo Neira Ayuso wrote:
> Hi Duncan,
>
> I would prefer user fixes provides a more detailed report on his
> build environment, or either compiler gets fixed.

I submitted a fresh patch with more detail - enough this time?
>
> My concern is that this may trigger similar patches for all of the
> userspace netfilter repository sooner or later.

That would alert a newcomer to the code base that headers are local.
It's easy enough to do (shell script plus [q] editor macros) but I'm fine with
waiting until someone complains if that's what you'd rather do.
>
> [...]
> > > diff --git a/extensions/ebt_802_3.c b/extensions/ebt_802_3.c
> > > index 4584849..3aa7ebe 100644
> > > --- a/extensions/ebt_802_3.c
> > > +++ b/extensions/ebt_802_3.c
> > > @@ -12,7 +12,7 @@
> > >  #include <getopt.h>
> > >  #include "../include/ebtables_u.h"
> > >  #include "../include/ethernetdb.h"
> > > -#include <linux/netfilter_bridge/ebt_802_3.h>
> > > +#include "linux/netfilter_bridge/ebt_802_3.h"

Cheers ... Duncan.

[q] https://github.com/duncan-roe/q
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux