Re: [PATCH] nftables: Fix typos/Grammatical Errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 15, 2018 at 07:27:37AM +0530, Arushi Singhal wrote:
> typos/Grammatical errors are corrected.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@xxxxxxxxx>
> ---
>  doc/nft.xml | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/doc/nft.xml b/doc/nft.xml
> index 3a5571b..8f463c6 100644
> --- a/doc/nft.xml
> +++ b/doc/nft.xml
> @@ -1433,7 +1433,7 @@ table inet filter {
>  			</cmdsynopsis>
>  		</para>
>  		<para>
> -			Stateful objects are attached to tables and are identified by an unique name. They group stateful information from rules, to reference them in rules the keywords "type name" are used e.g. "counter name".
> +			Stateful objects are attached to tables and are identified by a unique name. They group stateful information from rules, to reference them in rules the keywords "type name" are used e.g. "counter name".
>  		</para>
>
>  		<variablelist>
> @@ -1782,7 +1782,7 @@ cwr                           	0x80
>  				</table>
>  			</para>
>  			<para>
> -				The string type is used to for character strings. A string begins with an alphabetic character
> +				The string type is used for character strings. A string begins with an alphabetic character
>  				(a-zA-Z) followed by zero or more alphanumeric characters or the characters <literal>/</literal>,
>  				<literal>-</literal>, <literal>_</literal> and <literal>.</literal>. In addition anything enclosed
>  				in double quotes (<literal>"</literal>) is recognized as a string.
> @@ -4052,11 +4052,11 @@ ip6 nexthdr ipv6-frag counter
>  			</para>
>
>  			The raw payload expression instructs to load <replaceable>length</replaceable>bits starting at <replaceable>offset</replaceable>bits.
> -			Bit 0 refers the the very first bit -- in the C programming language, this corresponds to the topmost bit, i.e. 0x80 in case of an octet.
> +			Bit 0 refers to the very first bit -- in the C programming language, this corresponds to the topmost bit, i.e. 0x80 in case of an octet.
>  			They are useful to match headers that do not have a human-readable template expression yet.
>  			Note that nft will not add dependencies for Raw payload expressions.
> -			If you e.g. want to match protocol fields of a transport header with protocol number 5, you need to manually
> -			exclude packets that have a different transport header, for instance my using <literal>meta l4proto 5</literal> before
> +			If for e.g. you want to match protocol fields of a transport header with protocol number 5, you need to manually
> +			exclude packets that have a different transport header, for instance by using <literal>meta l4proto 5</literal> before
>  			the raw expression.
>
>  			<table frame="all">
> @@ -5467,7 +5467,7 @@ dup to ip daddr map { 192.168.7.1 : "eth0", 192.168.7.2 : "eth1" }
>  				Furthermore, any set that will be dynamically updated from the nftables ruleset must specify
>  				both a maximum set size (to prevent memory exhaustion) and a timeout (so that number of entries in
>  				set will not grow indefinitely).
> -				The set statement can be used to e.g. create dynamic blacklists.
> +				The set statement can be used for e.g. to create dynamic blacklists.
>  			</para>
>  			<para>
>  				<cmdsynopsis>
> --
> 2.7.4
>
Disagree with

> -If you e.g. want to match protocol fields of a transport header with protocol number 5, you need to manually
> +If for e.g. you want to match protocol fields of a transport header with protocol number 5, you need to manually

and

> -The set statement can be used to e.g. create dynamic blacklists.
> +The set statement can be used for e.g. to create dynamic blacklists.

In those 2 cases, I think the originals are better.

I'm happy with the other changes,

Cheers ... Duncan.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux