Re: [PATCH nf] netfilter: x_tables: initialise match/target check parameter struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 07, 2018 at 09:34:43PM +0200, Florian Westphal wrote:
> syzbot reports following splat:
> 
> BUG: KMSAN: uninit-value in ebt_stp_mt_check+0x24b/0x450
>  net/bridge/netfilter/ebt_stp.c:162
>  ebt_stp_mt_check+0x24b/0x450 net/bridge/netfilter/ebt_stp.c:162
>  xt_check_match+0x1438/0x1650 net/netfilter/x_tables.c:506
>  ebt_check_match net/bridge/netfilter/ebtables.c:372 [inline]
>  ebt_check_entry net/bridge/netfilter/ebtables.c:702 [inline]
> 
> The uninitialised access is
>    xt_mtchk_param->nft_compat
> 
> ... which should be set to 0.
> Fix it by zeroing the struct beforehand, same for tgchk.
> 
> ip(6)tables targetinfo uses c99-style initialiser, so no change
> needed there.

Applied, thanks Florian.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux