Re: [PATCH] iptables src: Use double quotes in #includes for local headers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 2018-06-05 20:04, Duncan Roe wrote:
>diff --git a/include/ip6tables.h b/include/ip6tables.h
>index 5f1c5b6..d95953e 100644
>--- a/include/ip6tables.h
>+++ b/include/ip6tables.h
>@@ -2,8 +2,8 @@
> #define _IP6TABLES_USER_H
> 
> #include <netinet/ip.h>
>-#include <xtables.h>
>-#include <libiptc/libip6tc.h>
>+#include "xtables.h"
>+#include "libiptc/libip6tc.h"
> #include <iptables/internal.h>

Whereas the other patches so far seemed to be mostly cosmetic, this one is
factually wrong.

ip6tables.h (and other files) get installed into /usr/include (as does
xtables.h), so you *DO* want <xtables.h> all the time.

>diff --git a/include/linux/filter.h b/include/linux/filter.h
>index a9ae93c..dc14392 100644
>--- a/include/linux/filter.h
>+++ b/include/linux/filter.h
>@@ -6,7 +6,7 @@
> #define __LINUX_FILTER_H__
> 
> 
>-#include <linux/types.h>
>+#include "linux/types.h"

This is a pointless exercise, these files (include/linux/) are copied from the
kernel, so any modifications will be lost at some point in the future.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux