Re: [PATCH v2] libmnl src: Use double quotes in #includes for non-system headers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 05, 2018 at 10:13:18AM +0200, Jan Engelhardt wrote:
> On Tuesday 2018-06-05 08:20, Duncan Roe wrote:
>
> >libmnl carries a private copy of a number of system headers. These were mostly
> >still being included with angle brackets as though they were system headers.
>
> These headers are willingly used in exactly that context: they are
> system headers, just at another location.
>
> >Tested configurations of gcc would pick up the private copy in these cases but
> >it has been reported that others do not.
>
> Seeing that report would be helpful.

https://marc.info/?l=netfilter-devel&m=152739396729786&w=3
>
[...]
>
Additionally, the following message was copied to the list, but I can't find it
in the archive:

----------

Date: Sun, 27 May 2018 01:02:46 -0400
From: Edriss Mirzadeh <edriss@xxxxxxxxx>
To: Duncan Roe <duncan_roe@xxxxxxxxxxxxxxx>
Cc: Netfilter Development <netfilter-devel@xxxxxxxxxxxxxxx>
Subject: Re: ebtables commit
X-Mailer: iPhone Mail (15E302)

Hi there,

I'm actually cross compiling Tomato Firmware using 64 bit Debian 9.

The build instructions are good at the below URL, except for the repo name which
recently changed but hasn't yet been updated in the readme instructions.

https://bitbucket.org/kille72/freshtomato-arm/src

This could well be due to either the cross-compilation or the very old tool
chain, or ancient kernel 2.6 (with many back ports), but I do agree that local
headers should be double quoted, so your thought on patch rings true in terms
of portability.

----------

Cheers ... Duncan.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux