On Thu, May 31, 2018 at 11:07:58AM +0200, Florian Westphal wrote: > Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Thu, May 31, 2018 at 10:24:36AM +0200, Florian Westphal wrote: > > > peter pi <tiangangpi@xxxxxxxxx> wrote: > > > > Hi Greg, I applied this patch on 4.4 and tested it on my Pixel 2, it seems > > > > the problem still exists, > > > > > > What is the problem exactly? > > > > The problem is that kernel data is being sent to userspace due to an > > uncleared buffer that was allocated and then copied to userspace. This > > can be reproduced by dumping the current set of iptables rules. Peter > > had an example reproducing script that he used to specifically show > > this. Peter, can you provide that? > > > > I thought that initializing this buffer to zero would solve the problem, > > but I guess I cleared the wrong buffer :( > > Never mind, this test was on 4.4 not 4.14. > > But even on 4.14 i don't see how zeroing a buffer that will > be filled via copy_from_user would help. It should be copy_to_user() :) -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
