Re: [PATCH] ebtables: fix limit and mark modules incompatibilities between 32-bit user space and 64-bit kernel space

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 28, 2018 at 06:07:29PM +0200, Alin Nastac wrote:
> Signed-off-by: Alin Nastac <alin.nastac@xxxxxxxxx>
> ---
>  include/linux/netfilter_bridge/ebt_limit.h  | 4 ++++
>  include/linux/netfilter_bridge/ebt_mark_m.h | 5 +++++
>  include/linux/netfilter_bridge/ebt_mark_t.h | 4 ++++
>  3 files changed, 13 insertions(+)
> 
> diff --git a/include/linux/netfilter_bridge/ebt_limit.h b/include/linux/netfilter_bridge/ebt_limit.h
> index 66d80b3..6db2443 100644
> --- a/include/linux/netfilter_bridge/ebt_limit.h
> +++ b/include/linux/netfilter_bridge/ebt_limit.h
> @@ -16,7 +16,11 @@ struct ebt_limit_info {
>  	__u32 burst;  /* Period multiplier for upper limit. */
>  
>  	/* Used internally by the kernel */
> +#ifdef KERNEL_64_USERSPACE_32
> +	uint64_t prev;
> +#else
>  	unsigned long prev;
> +#endif

Isn't CONFIG_COMPAT dealing with this already?

We used to do thse KERNEL_64_USERSPACE_32 ifdefs long long time ago,
and we removed it in favour of the CONFIG_COMPAT tricks.

Probably a bug in ebt_limit or missing code wrt.
net/netfilter/xt_limit.c?

>  	__u32 credit;
>  	__u32 credit_cap, cost;
>  };
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux