Re: [PATCH nftlb] src: add -W and compilation warnings that result from it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 11, 2018 at 02:50:46PM +0200, Pablo Neira Ayuso wrote:
> config.c: In function ‘config_file’:
> config.c:60:30: warning: ordered comparison of pointer with integer zero [-Wextra]
>   if ((fd = fopen(file, "r")) <= 0) {
>                               ^~
> 
> nft.c: In function ‘get_ndv_base’:
> nft.c:173:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
>   for (i = 0; i < n_ndv_base_rules; i++) {
>                 ^
> 
> Add -Wno-unused-parameter to silence the following warning:
> 
> onfig.c: In function ‘config_json_string’:
> config.c:142:46: warning: unused parameter ‘level’ [-Wunused-parame
>  void config_json_string(json_t *element, int level)
>                                               ^~~~~
> 
> since this may be intentional as all these functions take the level parameter.
> 

Applied, thank you Pablo!

https://github.com/zevenet/nftlb/commit/7921471fc99f59a333bfb97dbf90a02cf2522c16
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux