Re: [nft PATCH 0/4] Support 'add/insert rule index <IDX>'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 09, 2018 at 04:03:39PM +0200, Phil Sutter wrote:
> As discussed before, this patch series introduces 'handle' keyword to
> add/insert rule commands as a more intuitive and consistent alternative
> to 'position'.
> 
> On top of that, adding/inserting rules at an absolute position is
> implemented via the new 'index' keyword.

Series applied, thanks Phil.

One comment though regarding manpage:

+                       The <literal>add</literal> and <literal>insert</literal> commands support an optional
+                       location specifier, which is either a <replaceable>handle</replaceable> of an existing
+                       rule or an absolute <replaceable>index</replaceable> (starting at zero)

I think this new index is _relative_, since the counting depends on
the ruleset, while the handle is an _absolute_ way to refer to rules.
As you describe, index can be misleading since it depends on having no
interferences with the ongoing ruleset update.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux