Hi Kristian, Thank you for the patch! Yet something to improve: [auto build test ERROR on nf-next/master] [also build test ERROR on v4.17-rc3 next-20180503] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Kristian-Evensen/netfilter-nf_queue-Replace-conntrack-entry/20180504-051218 base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master config: x86_64-randconfig-s5-05041850 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): net/netfilter/nfnetlink_queue.o: In function `nfqnl_update_ct': >> net/netfilter/nfnetlink_queue.c:1062: undefined reference to `nf_ct_l3proto_find_get' >> net/netfilter/nfnetlink_queue.c:1069: undefined reference to `nf_ct_l4proto_find_get' >> net/netfilter/nfnetlink_queue.c:1071: undefined reference to `nf_ct_get_tuple' >> net/netfilter/nfnetlink_queue.c:1079: undefined reference to `nf_conntrack_find_get' vim +1062 net/netfilter/nfnetlink_queue.c 1046 1047 #if IS_ENABLED(CONFIG_NF_CONNTRACK) 1048 static void nfqnl_update_ct(struct net *net, struct sk_buff *skb) 1049 { 1050 const struct nf_conntrack_l3proto *l3proto; 1051 const struct nf_conntrack_l4proto *l4proto; 1052 struct nf_conntrack_tuple_hash *h; 1053 struct nf_conntrack_tuple tuple; 1054 enum ip_conntrack_info ctinfo; 1055 struct nf_conn *ct = NULL; 1056 unsigned int dataoff; 1057 u16 l3num; 1058 u8 l4num; 1059 1060 ct = nf_ct_get(skb, &ctinfo); 1061 l3num = nf_ct_l3num(ct); > 1062 l3proto = nf_ct_l3proto_find_get(l3num); 1063 1064 if (l3proto->get_l4proto(skb, skb_network_offset(skb), &dataoff, 1065 &l4num) <= 0) { 1066 return; 1067 } 1068 > 1069 l4proto = nf_ct_l4proto_find_get(l3num, l4num); 1070 > 1071 if (!nf_ct_get_tuple(skb, skb_network_offset(skb), dataoff, l3num, 1072 l4num, net, &tuple, l3proto, l4proto)) { 1073 return; 1074 } 1075 1076 #if IS_ENABLED(CONFIG_NF_CONNTRACK_ZONES) 1077 h = nf_conntrack_find_get(net, &ct->zone, &tuple); 1078 #else > 1079 h = nf_conntrack_find_get(net, NULL, &tuple); 1080 #endif 1081 1082 if (h) { 1083 pr_debug("%s: tuple %u %pI4:%hu -> %pI4:%hu\n", __func__, 1084 tuple.dst.protonum, &tuple.src.u3.ip, 1085 ntohs(tuple.src.u.all), &tuple.dst.u3.ip, 1086 ntohs(tuple.dst.u.all)); 1087 nf_ct_put(ct); 1088 ct = nf_ct_tuplehash_to_ctrack(h); 1089 nf_ct_set(skb, ct, IP_CT_NEW); 1090 } 1091 } 1092 #endif 1093 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
