Jack Ma <jack.ma@xxxxxxxxxxxxxxxxxxx> wrote: > This patch adds a new feature to iptables that allow bitshifting for > --restore,set and save-mark operations. This allows existing logic > operators (and, or and xor) and mask to co-operate with new bitshift > operations. > > The intention is to provide uses with more fexible uses of skb->mark > and ct->mark. For example, users can save extra bits in skb->mark: > skb->mark = ct->mark << 8; > > Reviewed-by: Florian Westphal <fw@xxxxxxxxx> I did not review this patch. Perhaps I did review an older version. But please only retain an earlier Reviewed-by tag if the patch only had little to no changes. > Signed-off-by: Jack Ma <jack.ma@xxxxxxxxxxxxxxxxxxx> > --- > extensions/libxt_CONNMARK.c | 286 ++++++++++++++++++++++++++++++++-- > include/linux/netfilter/xt_connmark.h | 5 + > 2 files changed, 279 insertions(+), 12 deletions(-) Here you could have added a small section: "Changes since v2:" and list what has been changed since the v2. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
